Modernize2 #137
Merged
Modernize2 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2022
Closed
|
Released to npm as v1.0.29 |
|
In my opinion, you'd ideally have some code to clean up the folders that are made during the test, be it if you're making them in a known spot or using mktempdir function. However, if you're willing to make minimum support to 12.x (which is the oldest currently supported LTS), could use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #134
closes #134
This PR contains a few simple commits meant to modernize the dependencies that had security vulnerabilities in them.
It also contains some code from @MasterOdin that attempts to fix the test setup. Note that I have left (but upgraded) mkdirp for now. We can revisit that a week from now. I will not be in town next week, so this release needs to be minimal as to not interrupt my vacation :).
With only dependency updates included in the main code, things should not change behavior wise in any shape or form. This should be completely safe and non breaking to merge. I will do so now, and make a release.
cc @MasterOdin fyi
ps tests all pass :) - we probably don't need the recursive fs.rmdir code but let me know your thoughts - it's only for the tests and I need to get these security updates out - I'll be around next weekend(a week from tomorrow) - I'll look deeper then, thanks for all your support and help lately ;)