-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle MacOS 10.11.5+ interface changes and VM use case #33
Conversation
- allow portfinder.getPort for all ports w/ os.networkInterfaces().internal === true - allow portfinder.getPort from netmask 255.255.255.0, which maps to default ip address of machine (en0) - allow portfinder.getPort to work from within a locally running VM assuming vnic0 or vnic1 use netmask 255.255.255.0 (aka, shared or bridged mode) - handle 0.0.0.0 host that while not output by os.networkInterfaces() is nonetheless a bindable host that exists and must be handled accordingly
cc @dbuhrman - does this fix your use case? (if you have time to check thanks, if not, no biggie) |
@eriktrom it seems good, but without tests its hard to see exactly what use-case this is addressing so Im not sure my feedback is that valuable as I haven't played with 10.11.x yet myself. |
@stefanpenner - thanks for the review - the tests did get an update - they iterate over the Gonna merge - if we find issues, I'll make another PR Thanks again for the review |
@indexzero - can you make a release to npm? Gratzi! |
@indexzero it would also be awesome if you could add @eriktrom as a collaborator on NPM to reduce the bus factor of this project |
@eriktrom @Turbo87 done. Feel free to publish at will. Good job here 👍
|
Thanks @indexzero 👍 |
Bump portfinder to v1.0.4 Adds support for/fixes issues outlined in http-party/node-portfinder#33
ip address given to default interface of machine (en0)
vnic0 or vnic1 use netmask 255.255.255.0 (aka, shared or bridged mode)
nonetheless a bindable host that exists and must be handled accordingly
cc @indexzero or @stefanpenner - need at least one pair of eyeballs on this one. Thanks!