Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow fetch on worker scripts(web-worker, service-worker) #23

Closed
wants to merge 68 commits into from
Closed

allow fetch on worker scripts(web-worker, service-worker) #23

wants to merge 68 commits into from

Conversation

extraymond
Copy link
Contributor

Hi! I've adapted the code copied from the gloo crate(related_section) to allow wasm-client to use fetch under worker environments.

Stumbled upon this when trying cloudflare workers(which is using service worker).

@extraymond extraymond changed the title allow fetch on worker scripts(web-worker, service-worker) [WIP] allow fetch on worker scripts(web-worker, service-worker) Mar 11, 2020
@extraymond extraymond changed the title [WIP] allow fetch on worker scripts(web-worker, service-worker) allow fetch on worker scripts(web-worker, service-worker) Mar 12, 2020
@extraymond extraymond mentioned this pull request Apr 18, 2020
Closed
@extraymond
Copy link
Contributor Author

extraymond commented Jun 2, 2020 •
edited
Loading

@yoshuawuyts Greetings! Would you mind giving me some guidance over making this PR into an acceptable state? While currently http-client -> surf supports running on wasm, it will only allow making requests on the windows_global_scope, which for users seeking to use it inside web-worker or service-worker will receive runtime error by using rust web_sys::window().unwrap()

This PR simply get the global_scope in runtime, so request and fetch api can be used alongside http-client -> surf.

@extraymond
Copy link
Contributor Author

rebase

@goto-bus-stop goto-bus-stop changed the base branch from master to main August 9, 2020 12:58
@yoshuawuyts
Copy link
Member

@extraymond hi! -- sorry for not catching this sooner; yes we should definitely merge this. If you can fix the merge conflicts we can merge + release it.

@extraymond
Copy link
Contributor Author

@yoshuawuyts No biggie, conflict resolved now.

@yoshuawuyts
Copy link
Member

@extraymond it seems the CI is currently failing to compile WASM, and it may also need a cargo fmt pass. Would you mind looking into that?

Fishrock123 and others added 25 commits November 5, 2020 23:40
@Fishrock123 @extraymond
isahc: simplify setting headers during request
8b43592 
This fixes a bug where duplicate headers would only use one value.

Possibly related to http-rs/surf#220
@jbr @extraymond
Switch to using async_trait
a55d9d4
@Fishrock123 @extraymond
curl_client: fix IsahcClient post-a943eb96e9
d26ec8d 
Fixes the IsahcClient to work wiith async_trait from
a943eb9
@Fishrock123 @extraymond
crate: cleanup Cargo.toml
d880dde
@Fishrock123 @extraymond
crate: don't select hyper features without hyper_client
2acea1b
@Fishrock123 @extraymond
crate: only include "futures" for wasm_client
0c483fb 
Only the wasm client uses it and it is not light.
@Fishrock123 @extraymond
meta: add CHANGELOG.md
c558976
@Fishrock123 @extraymond
5.0.0
3e8fba7
@Fishrock123 @extraymond
src: correctly translate hyper body stream to ours
164868d 
Fixes a bug from 8bcf81f
@Fishrock123 @extraymond
meta: fix changelog formatting
630820b
@Fishrock123 @extraymond
5.0.1
dff3265
@Fishrock123 @extraymond
src: remove Clone from HttpClient impls
cd5c6ca
@Fishrock123 @extraymond
h1: require constructor
60e0e83 
Prevents users from writing `HttpClient {}`.
@Fishrock123 @extraymond
6.0.0
b9f39b8
@Fishrock123 @extraymond
hyper: Clone & Default, re-use internal client
43f68bf 
- Makes HyperClient impl Clone and Default
- Re-uses the internal hyper client for pooling and alloc efficiency
- Adds HyperClient::from_client()
- Always uses the HttpsConnector (has internal http fallback)

Required for hyper-client in Surf:
http-rs/surf#234
@Fishrock123 @extraymond
hyper: avoid leaking generics into HttpClient
d98af0c 
Avoid leaking Hyper generics into HttpClient by hiding it behind a dynamic trait object pointer.
@Fishrock123 @extraymond
hyper: minor code improvements
7f854e4
@Fishrock123 @extraymond
hyper: remove Clone
7c36c33 
See #48
@Fishrock123 @extraymond
crate: update authors
cb23a1a
@Fishrock123 @extraymond
dev-deps: tide at 0.13
033ea03 
This fixes a forbid rust_2018_idioms issue.
@Fishrock123 @extraymond
6.1.0
6507fec 
This release brings improvements for `HyperClient` (`hyper_client` feature).

### Added
- `HyperClient` now impls `Default`.
- `HyperClient::from_client(hyper::Client<C>)`.

### Changed
- `HyperClient` now re-uses the internal client, allowing connection pooling.
@jbr @extraymond
add an implementation of HttpClient for Box<dyn HttpClient>
374256c
@Fishrock123 @extraymond
6.2.0
9e0f4d0
@extraymond
fix: rustfmt
2dea959
@extraymond
Merge branch 'worker_global_scope' of github.com:extraymond/http-clie…
3023ffc 
…nt into worker_global_scope
@extraymond
Copy link
Contributor Author

rebase again

@extraymond
Copy link
Contributor Author

It seems I'm messing stuff up.
Should have just do it all over again since it's only two code snippets...

@extraymond extraymond mentioned this pull request Nov 5, 2020
Merged
@extraymond extraymond closed this Nov 5, 2020
@extraymond
Copy link
Contributor Author

continue at #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@extraymond @yoshuawuyts @Fishrock123 @bspeice @Perseus101 @FreddieRidell @goto-bus-stop @rossdylan @strohel @jbr