Fix h1_client feature #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this fixes the issue in http-client 6.3.0, but is not the same behavior as http-client 6.2.0. |
* When both "native-tls" and "rustls" features are disabled, disable https. * When both "native-tls" and "rustls" features are enabled, prefer "rustls". This is the same behavior as http-client 6.2.0. Ideally, it would be nice if this behavior could be controlled by environment variables or some other way. This also adds a CI task to check all feature combinations work properly.
|
Thanks! Sorry I didn't catch this on the last release. |
|
Released in 6.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #67 (comment)
This is the same behavior as http-client 6.2.0.
Ideally, it would be nice if this behavior could be controlled by
environment variables or some other way.
This also adds a CI task to check all feature combinations work properly. (see http-rs/surf#282 for more)