Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Clone from StatusCode #323

Closed
Fishrock123 opened this issue Jan 19, 2021 · 1 comment
Closed

Remove Clone from StatusCode #323

Fishrock123 opened this issue Jan 19, 2021 · 1 comment
Labels
semver-major This change requires a semver major change

Comments

@Fishrock123
Copy link
Member

Mentioned in #319 (comment) StatusCode is Clone, but it's also Copy, as it is just a wrapper around u16. I think we should remove Clone from it since it doesn't really make sense.
@Fishrock123 Fishrock123 added the semver-major This change requires a semver major change label Jan 19, 2021
@yoshuawuyts
Copy link
Member

Copy has a requirement on Clone. It's defined as:

pub trait Copy: Clone { }

We can't remove Clone for that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver-major This change requires a semver major change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fishrock123 @yoshuawuyts