Add peer and local socket addrs, as well as Request::remote #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbr
changed the title
jbr
changed the title
jbr
changed the title
in order to accommodate future filesystem sockets
yoshuawuyts
requested changes
May 7, 2020
|
Addressed all changes, thanks for the review! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the first PR of three to address http-rs/tide#462
This also adds an initial implementation of Request::remote and Request::forwarded_for. Parsing the Forwarded header value probably would be more elegant with a proper parsing or regex library, but I didn't want to add an additional dependency just for this.