Rewrite Forwarded header module #508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of `Forwarded` header parsing didn't implement anything closely resembling the specification of the `Forwarded` header in RFC 7239 and would fail on almost any real-world `Forwarded` header with more than one proxy, or with the parameters in a different order from what it expected. This commit tries to implement the specification as accurately as possible. Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
kyrias
force-pushed
the
rewrite-forwarded-module
branch
from
4d284ff
to
c8e1d51
Compare
OneOfOne
added a commit
to OneOfOne/http-types-rs
that referenced
this pull request
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
Forwardedheader parsing didn'timplement anything closely resembling the specification of the
Forwardedheader in RFC 7239 and would fail on almost any real-worldForwardedheader with more than one proxy, or with the parameters in adifferent order from what it expected.
This commit tries to implement the specification as accurately as possible.