You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@liufuyang did an excellent job implementing the current multipart support and I'm flattered he chose my crate, but I'm worried about the scalability of collecting the entire request body to Vec<u8>, as you typically don't want to keep whole files in memory.
I have multipart-async which is designed to parse a multipart body from an async stream but it has languished a bit as I was waiting for the futures churn to settle and then I kind of forgot about it.
I'll be coming back to it and fixing it up, and I'd be glad to consult on/mentor a refactoring of Tide's multipart support to use it, or even another crate if there is one.
The text was updated successfully, but these errors were encountered:
I tried implementing some kind of adapter that would store buffered values from AsyncBufRead and implement Stream, but looks like I'm not experienced enough to do that.
@liufuyang did an excellent job implementing the current multipart support and I'm flattered he chose my crate, but I'm worried about the scalability of collecting the entire request body to
Vec<u8>
, as you typically don't want to keep whole files in memory.I have
multipart-async
which is designed to parse a multipart body from an async stream but it has languished a bit as I was waiting for the futures churn to settle and then I kind of forgot about it.I'll be coming back to it and fixing it up, and I'd be glad to consult on/mentor a refactoring of Tide's multipart support to use it, or even another crate if there is one.
The text was updated successfully, but these errors were encountered: