Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect submodule #450

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Add redirect submodule #450

merged 1 commit into from
Apr 23, 2020

Conversation

yoshuawuyts
Copy link
Member

@yoshuawuyts yoshuawuyts commented Apr 22, 2020

Follow-up to #435. Now supports both permanent and temporary redirects, and updated all vocabulary in Tide to be consistent with one another. Thanks!

edit: closes #82

Screenshot

Tide's docs landing now looks really clean:

Screenshot_2020-04-22 tide - Rust

Now supports both permanent and temporary redirects, and updated all vocabulary in Tide to be consistent with one another.
@petejodo
Copy link
Collaborator

do you think this satisfies #82?

@yoshuawuyts
Copy link
Member Author

@petejodo yes!

@tirr-c
Copy link
Collaborator

tirr-c commented Apr 23, 2020

@yoshuawuyts #82 seems more like URL rewrites, rather than actual HTTP redirects.

@yoshuawuyts yoshuawuyts merged commit c1fb3cf into master Apr 23, 2020
@yoshuawuyts
Copy link
Member Author

@tirr-c ah yes, you're right!

@yoshuawuyts yoshuawuyts mentioned this pull request Apr 23, 2020
@yoshuawuyts yoshuawuyts deleted the redirect-submodule branch April 23, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal redirects
3 participants