Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request+Response AsRef and Into impls for inner context access #510

Merged
merged 2 commits into from
May 18, 2020
Merged

Request+Response AsRef and Into impls for inner context access #510

merged 2 commits into from
May 18, 2020

Conversation

Fishrock123
Copy link
Member

Part of #465

jbr
jbr approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Fishrock123
Copy link
Member Author 

     Running target\debug\deps\server-c0d59325d3b23d0f.exe

running 3 tests
error: test failed, to rerun pass '--test server'
##[error]test failed, to rerun pass '--test server'
Caused by:
  process didn't exit successfully: `d:\a\tide\tide\target\debug\deps\server-c0d59325d3b23d0f.exe` (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)

Well that's a useful message...

@Fishrock123 Fishrock123 force-pushed the request-response-impl-asref-and-into branch from 8669d5c to 68fc590 Compare May 17, 2020 19:43
@Fishrock123
Copy link
Member Author

Fishrock123 commented May 17, 2020 •
edited
Loading

Ah shoot, I forget AsMut...

@Fishrock123 Fishrock123 force-pushed the request-response-impl-asref-and-into branch from 68fc590 to 2024ed2 Compare May 17, 2020 22:19
yoshuawuyts
yoshuawuyts approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@yoshuawuyts yoshuawuyts merged commit 8850cbb into http-rs:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbr jbr jbr approved these changes

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fishrock123 @jbr @yoshuawuyts