Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove executable mode from lib.rs #635

Merged
merged 1 commit into from Jul 9, 2020
Merged

Remove executable mode from lib.rs #635

merged 1 commit into from Jul 9, 2020

Conversation

pbzweihander
Copy link
Contributor

Description

Remove x mode from lib.rs file

Motivation and Context

lib.rs was marked as executable file at this commit: 815c331#diff-b4aea3e418ccdb71239b96952d9cddb6

I think there is no particular reason to be executable. Maybe a mistake.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jbr
Copy link
Member

jbr commented Jul 9, 2020 •
edited

Thanks (and nice catch)!

@jbr jbr merged commit 9a6464d into http-rs:master Jul 9, 2020
@pbzweihander pbzweihander deleted the remove-x-from-lib-rs branch July 13, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pbzweihander @jbr