Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate project to axum #287

Merged
merged 5 commits into from
May 15, 2023
Merged

feat: migrate project to axum #287

merged 5 commits into from
May 15, 2023

Conversation

EstebanBorai
Copy link
Member

No description provided.

@EstebanBorai EstebanBorai merged commit 6b36912 into main May 15, 2023
7 checks passed
@EstebanBorai EstebanBorai deleted the feat/axum branch May 15, 2023 01:24
@Miuler Miuler mentioned this pull request May 31, 2023
@Miuler
Copy link

Miuler commented May 31, 2023

This PR is related to the issue #284

@Miuler
Copy link

Miuler commented May 31, 2023

@EstebanBorai what happened to these arguments?

 config: None,
 host: "127.0.0.1".parse().unwrap(),
 port: 7878_u16,
 root_dir: PathBuf::from_str("./").unwrap(),
 verbose: false,
 tls: false,
 tls_cert: PathBuf::from_str("cert.pem").unwrap(),
 tls_key: PathBuf::from_str("key.rsa").unwrap(),
 tls_key_algorithm: PrivateKeyAlgorithm::Rsa,
 cors: false,
 gzip: false,
 username: None,
 password: None,
 logger: false,
 proxy: None,
 graceful_shutdown: false,

I only see these arguments:

    pub host: IpAddr,
    /// The port to listen on
    #[arg(long, default_value = "7878")]
    pub port: u16,
    /// Root directory for File Explorer
    #[arg(long, default_value = "./")]
    pub root_dir: PathBuf,

@EstebanBorai
Copy link
Member Author

@EstebanBorai what happened to these arguments?

 config: None,

 host: "127.0.0.1".parse().unwrap(),

 port: 7878_u16,

 root_dir: PathBuf::from_str("./").unwrap(),

 verbose: false,

 tls: false,

 tls_cert: PathBuf::from_str("cert.pem").unwrap(),

 tls_key: PathBuf::from_str("key.rsa").unwrap(),

 tls_key_algorithm: PrivateKeyAlgorithm::Rsa,

 cors: false,

 gzip: false,

 username: None,

 password: None,

 logger: false,

 proxy: None,

 graceful_shutdown: false,

I only see these arguments:

    pub host: IpAddr,

    /// The port to listen on

    #[arg(long, default_value = "7878")]

    pub port: u16,

    /// Root directory for File Explorer

    #[arg(long, default_value = "./")]

    pub root_dir: PathBuf,

Hi! The project migration is a work in progress. You can find more details in this issue: #284

Theres also a milestone which list all the tasks to complete before consider the migration completed!

Feel free to participate on any issue by commenting or opening a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants