Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file list overflow #369

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Conversation

Antosser
Copy link
Contributor

With these changes

  • Table cell will not overflow
    image
  • Status bar will not cover up the table behind itself
    image

@Antosser
Copy link
Contributor Author

#360 #361

Copy link
Member

@EstebanBorai EstebanBorai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@EstebanBorai EstebanBorai changed the title Overflow fix fix: file list overflow Oct 26, 2023
@EstebanBorai
Copy link
Member

@Antosser con you please run cargo clippy --fix?

@Antosser
Copy link
Contributor Author

I didn't introduce any of those clippy warnings but aight

@Antosser
Copy link
Contributor Author

@Antosser con you please run cargo clippy --fix?

I have done it, but I don't understand why this would belong into this pull request. Modifying the same files in multiple pull requests can lead to merge conflicts. Besides, this issue has nothing to do with the pull request

@EstebanBorai EstebanBorai merged commit e13e59f into http-server-rs:main Oct 28, 2023
6 of 7 checks passed
@Antosser Antosser deleted the overflow_fix branch October 28, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue Report] last<tr> overflows the table [Issue Report] Text overflows if file name is too long
2 participants