Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sort by date created/modified #373

Merged
merged 9 commits into from
Nov 3, 2023
Merged

feat: sort by date created/modified #373

merged 9 commits into from
Nov 3, 2023

Conversation

Antosser
Copy link
Contributor

No description provided.

EstebanBorai
EstebanBorai reviewed Oct 28, 2023
View reviewed changes
src/addon/file_server/directory_entry.rs Outdated Show resolved Hide resolved
src/addon/file_server/directory_entry.rs Outdated Show resolved Hide resolved
src/addon/file_server/mod.rs Outdated Show resolved Hide resolved
src/addon/file_server/template/explorer.hbs Outdated Show resolved Hide resolved
@EstebanBorai EstebanBorai changed the title feat: Add ability to sort by date created/modified feat: sort by date created/modified Oct 28, 2023
Antosser and others added 2 commits October 29, 2023 11:16
@Antosser @EstebanBorai
Add empty line after chrono::Local import
aa656ec 
Co-authored-by: Esteban Borai <estebanborai@gmail.com>
@Antosser
Implement using handlebars_helper
7e0c52b
EstebanBorai
EstebanBorai reviewed Oct 29, 2023
View reviewed changes
Copy link
Member

@EstebanBorai EstebanBorai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better! Just some minor improvements!

src/addon/file_server/mod.rs Outdated Show resolved Hide resolved
src/addon/file_server/mod.rs Outdated Show resolved Hide resolved
src/addon/file_server/mod.rs Outdated Show resolved Hide resolved
EstebanBorai
EstebanBorai approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@EstebanBorai EstebanBorai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@EstebanBorai EstebanBorai merged commit 04d73b7 into http-server-rs:main Nov 3, 2023
7 checks passed
@Antosser Antosser deleted the datetimesort branch November 4, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EstebanBorai EstebanBorai EstebanBorai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Antosser @EstebanBorai