fix(config): --spa
implies --index
option
#422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If #420 there was still an issue that
--spa would work very weirdly without
--index; single page applications are never implemented without also using
index.htmlfiles. This PR fixes this by automatically setting
cli.indexto
trueif
cli.spa` is set to true.I could throw an error if the
--index
flag is not passed in with--spa
, but I think those are way too many keystrokes for a feature someone would already expectI manually tested this and it works great for every case