Ensures response is handled with the same guest as the request #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we had a bug where an arbitrary module was used for response processing. This defeated the goal of request context correlation. This fixes the problem by holding the guest module open until the response is complete. Fixes #68 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
pushed a commit
to codefromthecrypt/components-contrib
that referenced
this pull request
May 23, 2023
@Taction noticed a pretty bad bug where request correlation could be out-of-sync. This is fixed in http-wasm v0.5.0 per http-wasm/http-wasm-host-go#69 Signed-off-by: Adrian Cole <adrian@tetrate.io>
1 task
codefromthecrypt
pushed a commit
to codefromthecrypt/components-contrib
that referenced
this pull request
May 23, 2023
@Taction noticed a pretty bad bug where request correlation could be out-of-sync. This is fixed in http-wasm v0.5.0 per http-wasm/http-wasm-host-go#69 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
pushed a commit
to codefromthecrypt/components-contrib
that referenced
this pull request
May 23, 2023
@Taction noticed a pretty bad bug where request correlation could be out-of-sync. This is fixed in http-wasm v0.5.0 per http-wasm/http-wasm-host-go#69 Signed-off-by: Adrian Cole <adrian@tetrate.io>
3 tasks
|
forgot docs #78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we had a bug where an arbitrary module was used for response processing. This defeated the goal of request context correlation. This fixes the problem by holding the guest module open until the response is complete.
Fixes #68