Removing the PAD_HIGH flag and Pad High field #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added a commit
that referenced
this pull request
Jun 6, 2014
Removing the PAD_HIGH flag and Pad High field. Closes #505.
kapsterio
pushed a commit
to kapsterio/netty
that referenced
this pull request
Nov 5, 2019
Motivation: Padding was removed from CONTINUATION frame in http2-spec, as showed in [PR](httpwg/http2-spec#510). We should follow it. Modifications: - Remove padding when writing CONTINUATION frame in DefaultHttp2FrameWriter - Add a unit test for writing large header with padding Result: More spec-compliant
normanmaurer
pushed a commit
to netty/netty
that referenced
this pull request
Nov 5, 2019
Motivation: Padding was removed from CONTINUATION frame in http2-spec, as showed in [PR](httpwg/http2-spec#510). We should follow it. Modifications: - Remove padding when writing CONTINUATION frame in DefaultHttp2FrameWriter - Add a unit test for writing large header with padding Result: More spec-compliant
normanmaurer
pushed a commit
to netty/netty
that referenced
this pull request
Nov 5, 2019
Motivation: Padding was removed from CONTINUATION frame in http2-spec, as showed in [PR](httpwg/http2-spec#510). We should follow it. Modifications: - Remove padding when writing CONTINUATION frame in DefaultHttp2FrameWriter - Add a unit test for writing large header with padding Result: More spec-compliant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for #505.