You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
another one, we'll take a look at pushing a pr to you for this one. with normal routes, you do a regex matcher on the path, but for resources you do string starts with. that means that you can't use wildcards as there's no regex handling, but also if you have multiple routes at different levels, you might have the wrong ones catch the wrong resource (say /ui/data and /ui routes would both match for a resource at /ui/data, though if you put them in the wrong order you're a numpty anyway). the issue we're seeing is we want the resource route to support the wildcards (as an example, we build our ui via react but package it as a single page js into the server rather than run a node server just for the ui, so we're trying to mirror the wildcard support in react router to pass the server routes through to react)
The line in question if in org.http4k.routing.internal.kt line 26.
obviously there's others matches you use to fallback to index.html so we'll see what comes out, but that's the area we're looking into , not sure if that's something you're already looking at as well though.
thanks!
The text was updated successfully, but these errors were encountered:
another one, we'll take a look at pushing a pr to you for this one. with normal routes, you do a regex matcher on the path, but for resources you do string starts with. that means that you can't use wildcards as there's no regex handling, but also if you have multiple routes at different levels, you might have the wrong ones catch the wrong resource (say /ui/data and /ui routes would both match for a resource at /ui/data, though if you put them in the wrong order you're a numpty anyway). the issue we're seeing is we want the resource route to support the wildcards (as an example, we build our ui via react but package it as a single page js into the server rather than run a node server just for the ui, so we're trying to mirror the wildcard support in react router to pass the server routes through to react)
The line in question if in org.http4k.routing.internal.kt line 26.
obviously there's others matches you use to fallback to index.html so we'll see what comes out, but that's the area we're looking into , not sure if that's something you're already looking at as well though.
thanks!
The text was updated successfully, but these errors were encountered: