Use correct methodName in generated code
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,4 +9,5 @@ service TestService { | |||
| rpc clientStreaming (stream TestMessage) returns (TestMessage); | |||
| rpc serverStreaming (TestMessage) returns (stream TestMessage); | |||
| rpc bothStreaming (stream TestMessage) returns (stream TestMessage); | |||
| rpc export (TestMessage) returns (TestMessage); | |||
There was a problem hiding this comment.
Just to confirm the call would be Export if this was capitalized right? Relevant to the reproducing example is why I ask.
There was a problem hiding this comment.
Yup, but the *scala method name is still lowercase.
ChristopherDavenport
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.