Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-mima-plugin to 0.5.0 #50

Merged

Conversation

scala-steward
Copy link
Contributor

Updates com.typesafe:sbt-mima-plugin from 0.3.0 to 0.5.0.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [{ groupId = "com.typesafe", artifactId = "sbt-mima-plugin" }]

labels: semver-minor

build.sbt Outdated
.settings(crossScalaVersions := Nil)
.settings(
crossScalaVersions := Nil,
mimaFailOnNoPrevious := false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't mix in mimaSettings, and since we don't publish the root, I think we don't want to. I'm not sure the cleanest way to handle this, but this works.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.disablePlugins(MimaPlugin) should work too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that a lot better. Thanks!

@ChristopherDavenport ChristopherDavenport merged commit ccc3e01 into http4s:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants