Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parent/acceptor event loop group, use setIoRatio with epoll #262

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

wjoel
Copy link
Contributor

@wjoel wjoel commented Apr 14, 2022

No description provided.

@wjoel
Copy link
Contributor Author

wjoel commented Apr 14, 2022

I'll re-target for series/0.4 later today.

@wjoel wjoel changed the base branch from main to series/0.4 April 14, 2022 14:12
@wjoel wjoel changed the base branch from series/0.4 to main April 14, 2022 14:16
@wjoel
Copy link
Contributor Author

wjoel commented Apr 14, 2022

Not re-targeting after all, as this conflicts with 34bc4fb - that commit does much the same as this, but doesn't allow for using different setIoRatio for the boss/parent/acceptor and the workers, as vert.x does with 100 in https://github.com/eclipse-vertx/vert.x/blob/daf5bbcc65eea5829556bb03ba0d30085d187dba/src/main/java/io/vertx/core/impl/VertxImpl.java#L158

@hamnis
Copy link
Collaborator

hamnis commented Apr 14, 2022

Lets do this instead. My approach was just to avoid duplication.

Needs a scalafmt.

@hamnis hamnis merged commit 14b2654 into http4s:main Apr 14, 2022
@hamnis
Copy link
Collaborator

hamnis commented Apr 14, 2022

Merged then backported to series/0.4

@wjoel wjoel deleted the parent-event-loop branch April 14, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants