Fix error handling in the Http4sNettyHandler #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem There are a couple things wrong with error handling in the Http4sNettyHandler. - The `sendSimpleErrorResponse` method doesn't flush the message so the pipeline will stall out in the common case. - The recover block in the Future composition that is part of the `channelRead` method suggests it's for handling failed writes but thats not the case: write failures will bubble up through the netty ChannelFuture, not be throw synchronously. The errors that will be propagated to the recover block will be things that passed by the `ServiceErrorHandler`, which should be considered 500's and probably represent a configuration issue. Solution Flush our error responses and refactor the error handling in the Future composition blocks. Also add a test.
|
Failure is unrelated to this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are a couple things wrong with error handling in the
Http4sNettyHandler.
sendSimpleErrorResponsemethod doesn't flush the message so thepipeline will stall out in the common case.
channelReadmethod suggests it's for handling failed writes butthats not the case: write failures will bubble up through the netty
ChannelFuture, not be throw synchronously. The errors that will be
propagated to the recover block will be things that passed by the
ServiceErrorHandler, which should be considered 500's and probablyrepresent a configuration issue.
Solution
Flush our error responses and refactor the error handling in the Future
composition blocks.
Also add a test.