Merge series/0.5 to main #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-4.1.84.Final Update netty-codec-http, ... to 4.1.84.Final in series/0.5
…streams-http-2.0.7 Update netty-reactive-streams-http to 2.0.7 in series/0.5
Executed command: sbt githubWorkflowGenerate
….13.10 Update scala-library to 2.13.10 in series/0.5
…0.14.7 Update sbt-http4s-org to 0.14.7 in series/0.5
Update proxyee to 1.7.0 in series/0.5
….6.1 Update scalafmt-core to 3.6.1 in series/0.5
Update sbt to 1.7.3 in series/0.5
Executed command: sbt githubWorkflowGenerate
…3.2.1 Update scala3-library to 3.2.1 in series/0.5
Update sbt to 1.8.0 in series/0.5
…-transport-classes-io_uring-0.0.16.Final Update netty-incubator-transport-classes-io_uring, ... to 0.0.16.Final in series/0.5
…p-4.1.85.Final Update netty-codec-http, ... to 4.1.85.Final in series/0.5
Websocket client
Executed command: sbt githubWorkflowGenerate
…3.2.2 Update scala3-library to 3.2.2 in series/0.5
…-transport-classes-io_uring-0.0.17.Final Update netty-incubator-transport-classes-io_uring, ... to 0.0.17.Final in series/0.5
Problem Right now we support HTTP/2 only as a negotiated protocol via ALPN. This is unfortunate as HTTP/2 is just as good cleartext as it is over TLS. Solution Add HTTP/2 prior knowledge detection to the cleartext pathway for the server. This is done by looking for the magic preface which is not valid as a HTTP/1.x message preface and initialize the pipeline accordingly.
Add support for HTTP/2 Prior Knowledge to the server implementation
* Shared Http4sHandler * Add callback queue to allow requests to be underway * Use same future trick as in server to work as a queue * do not unregister handler, as that causes strange problems * Add mima exclusions * Use client test battery and upgrade to cats-effect-munit 2 * Add mitigation to help with request splitting attack * parallel requests now work
ChannelPoolMap can run the request
This should hopefully stabilize the websocket client * MIMA * safe callback * back to traverse * Re-enable websocket-aggragator and move timeout to correct place
Update cats-effect to 3.4.6 in series/0.5
* drain queue when closed * release frame
We check if the channel is closed before we submit the dispatch to the channels executor, so if the channel is initially active but closes before we enter the executor we will put a request in the queue and it will sit there forever. Instead, check that the channel is active right before dispatching. This closes the window for the race condition.
Fix a race condition where a client channel closes and leaves a dispatch hanging
try to avoid deadlock for websockets
use unsafeRunAndForget where applicable unsafeRunSync onNext since ordering matters comments for dispatcher and eventloop
Avoid deadlock websocket client
make sure we call all enqueued callbacks
http client - even safer dispatch
This was referenced Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.