Fix danger of boolean blindness #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthPortal
force-pushed
the
boolean-blindness/PR
branch
from
91a67fa
to
b29bb15
Compare
NthPortal
commented
Apr 25, 2024
| @@ -0,0 +1 @@ | |||
| updates.ignore = [ { groupId = "org.slf4j", artifactId = "slf4j-simple" } ] | |||
There was a problem hiding this comment.
sneaking this into this PR as I can't be bothered to make a separate branch, commit and PR for it
NthPortal
commented
Apr 26, 2024
core/src/main/scala/org/http4s/otel4s/middleware/ServerMiddleware.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/http4s/otel4s/middleware/ServerMiddleware.scala
Outdated
Show resolved
Hide resolved
rossabaker
approved these changes
May 3, 2024
NthPortal
force-pushed
the
boolean-blindness/PR
branch
from
f2a7ac7
to
b83cb9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.