Use otel4s-sdk-trace-testkit to run tests across all platforms
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
commented
May 4, 2024
iRevive
force-pushed
the
otel4s-sdk-trace-testkit
branch
from
0314fe4
to
d16a588
Compare
iRevive
force-pushed
the
otel4s-sdk-trace-testkit
branch
from
d16a588
to
e32b640
Compare
NthPortal
approved these changes
May 6, 2024
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
otel4s-sdk-trace-testkitto run tests across all platforms.Side note: there is still a chance
otel4s-sdkandotel4s-oteljavamay behave slightly different in non-trivial cases. However, a shared test suite ensures both implementations behave identically in the most common scenarios.