Migrate to Cats-Effect 3.x #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@armanbilge Wouldn't you mind glancing at this few-liner?... |
armanbilge
reviewed
Mar 12, 2023
build.sbt
Outdated
| @@ -40,11 +35,11 @@ lazy val core = project | |||
| libraryDependencies ++= Seq( | |||
| "org.typelevel" %% "cats-core" % catsV, | |||
| "org.typelevel" %% "cats-effect" % catsEffectV, | |||
| "io.chrisdavenport" %% "random" % "0.0.2", | |||
| "io.chrisdavenport" %% "mapref" % "0.1.1", | |||
| "io.chrisdavenport" %% "mapref" % "0.2.1", | |||
There was a problem hiding this comment.
We have MapRef in CE std now, I wonder if this dependency is still needed?
There was a problem hiding this comment.
I left it since there is a version of mapref on CE 3 from io.chrisdavenport, and have removed random since it lacks CE 3 support. But yeah, let's migrate that one too 👍🏻
| numShards: Int = 4, | ||
| numBytes: Int = 32 // The session ID length must be at least 128 bits (16 bytes) | ||
| // numBytes is entropy / 2 SecureRandom | ||
| ): F[SessionStore[F, A]] = for { | ||
| random <- Random.javaSecuritySecureRandom(numShards) | ||
| random <- SecureRandom.javaSecuritySecureRandom(numShards) | ||
| ref <- MapRef.ofShardedImmutableMap[F, SessionIdentifier, A](numShards) |
There was a problem hiding this comment.
Yeah, I think this one is in CE now :)
|
It is good to go, I suppose. Arman, thanks for reviewing. If something has to be changed, I will do a follow-up PR doubtless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.