Skip to content

Commit

Permalink
Added deprecation to authInfo
Browse files Browse the repository at this point in the history
  • Loading branch information
hamnis committed Oct 30, 2019
1 parent 3fd0129 commit 96758df
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
3 changes: 2 additions & 1 deletion core/src/main/scala/org/http4s/ContextRequest.scala
Expand Up @@ -6,8 +6,9 @@ import cats.data.Kleisli

final case class ContextRequest[F[_], A](context: A, req: Request[F]) {
def mapK[G[_]](fk: F ~> G): ContextRequest[G, A] =
ContextRequest(authInfo, req.mapK(fk))
ContextRequest(context, req.mapK(fk))

@deprecated("Use context instead", "0.21.0")
def authInfo: A = context

}
Expand Down
2 changes: 1 addition & 1 deletion docs/src/main/tut/auth.md
Expand Up @@ -131,7 +131,7 @@ error handling, we recommend an error [ADT] instead of a `String`.
```tut:silent
val authUser: Kleisli[IO, Request[IO], Either[String,User]] = Kleisli(_ => IO(???))
val onFailure: AuthedRoutes[String, IO] = Kleisli(req => OptionT.liftF(Forbidden(req.authInfo)))
val onFailure: AuthedRoutes[String, IO] = Kleisli(req => OptionT.liftF(Forbidden(req.context)))
val middleware = AuthMiddleware(authUser, onFailure)
val service: HttpRoutes[IO] = middleware(authedRoutes)
Expand Down
2 changes: 1 addition & 1 deletion dsl/src/main/scala/org/http4s/dsl/impl/Auth.scala
Expand Up @@ -5,6 +5,6 @@ import org.http4s.{AuthedRequest, Request}
trait Auth {
object as {
def unapply[F[_], A](ar: AuthedRequest[F, A]): Option[(Request[F], A)] =
Some(ar.req -> ar.authInfo)
Some(ar.req -> ar.context)
}
}
Expand Up @@ -18,7 +18,7 @@ class AuthMiddlewareSpec extends Http4sSpec {
Kleisli.pure(Left("Unauthorized"))

val onAuthFailure: AuthedRoutes[String, IO] =
Kleisli(req => OptionT.liftF(Forbidden(req.authInfo)))
Kleisli(req => OptionT.liftF(Forbidden(req.context)))

val authedRoutes: AuthedRoutes[User, IO] =
AuthedRoutes.of {
Expand All @@ -41,7 +41,7 @@ class AuthMiddlewareSpec extends Http4sSpec {
Kleisli.pure(Right(userId))

val onAuthFailure: AuthedRoutes[String, IO] =
Kleisli(req => OptionT.liftF(Forbidden(req.authInfo)))
Kleisli(req => OptionT.liftF(Forbidden(req.context)))

val authedRoutes: AuthedRoutes[User, IO] =
AuthedRoutes.of {
Expand All @@ -63,7 +63,7 @@ class AuthMiddlewareSpec extends Http4sSpec {
Kleisli.pure(Right(userId))

val onAuthFailure: AuthedRoutes[String, IO] =
Kleisli(req => OptionT.liftF(Forbidden(req.authInfo)))
Kleisli(req => OptionT.liftF(Forbidden(req.context)))

val authedRoutes: AuthedRoutes[User, IO] =
AuthedRoutes.of {
Expand Down

0 comments on commit 96758df

Please sign in to comment.