Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GZip client side middleware #1327

Closed
agourlay opened this issue Aug 21, 2017 · 5 comments
Closed

GZip client side middleware #1327

agourlay opened this issue Aug 21, 2017 · 5 comments
Labels
enhancement Feature requests and improvements

Comments

@agourlay
Copy link

Currently the GZip middleware is only for server side.

The client could either reuse the server side middleware or just the compression logic added to a client side middleware.

Discussed on Gitter https://gitter.im/http4s/http4s?at=599aef13c101bc4e3a3f7b71

@agourlay
Copy link
Author

FYI I am currently working on this

@rossabaker
Copy link
Member

Which version are you targeting?

  • If it's 0.18, cool.
  • If it's 0.16 or 0.17 and you're only adding signatures, cool.
  • If it's 0.16 or 0.17 and it needs to change any signatures, let's plan, because I'm about to cut RCs.

@agourlay
Copy link
Author

I am gonna go for 0.18 to get complete freedom :bowtie:

@rossabaker rossabaker added the enhancement Feature requests and improvements label Mar 26, 2018
@rossabaker
Copy link
Member

#1373 was accidentally closed. That's a good starting point if anyone wants to pick this up and finish it.

@agourlay
Copy link
Author

agourlay commented Jul 8, 2019

fixed by #2673

@agourlay agourlay closed this as completed Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements
Projects
None yet
Development

No branches or pull requests

2 participants