No way to access close frame in WebSocketBuilder

[armanbilge]

http4s/server/shared/src/main/scala/org/http4s/server/websocket/WebSocketBuilder2.scala

Lines 76 to 77 in faf2436

	def withOnClose(onClose: F[Unit]): WebSocketBuilder2[F] =
	copy(onClose = onClose)

Also, at least ember server is not including the close frame in the Stream of incoming frames /shrug

[monzonj]

Hello.

I confirm this, but only applies to http4s-ember-server, it works fine with Blaze

For example, a simple websocket that logs all income messages. I expect "close" control frames to also be printed out

EmberServerBuilder
          .default[IO]
          .withHost("0.0.0.0")
          .withPort(8080)
          .withHttpWebSocketApp { builder =>
            HttpRoutes
              .of[IO] { case GET -> Root / "endpoint" =>
                val inOut: Pipe[IO, WebSocketFrame, WebSocketFrame] =
                  _.map { m =>
                    println(m.toString)
                    m
                  }
                builder.build(inOut)
              }
              .orNotFound
          }
          .build

You can run this server and test with https://websocketking.com/. Open a WS there and then close it... no printout.

All right, let's do the same with the Blazer server

BlazeServerBuilder[IO]
          .bindHttp("0.0.0.0", 8080)
          .withHttpWebSocketApp { builder =>
            HttpRoutes
              .of[IO] { case GET -> Root / "endpoint" =>
                val inOut: Pipe[IO, WebSocketFrame, WebSocketFrame] =
                  _.map { m =>
                    println(m.toString)
                    m
                  }
                builder.build(inOut)
              }
              .orNotFound
          }
          .serve

Same test and yes, the close frame is received and printed out

Seems a bug in the new Ember server.