New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Rfc2616 parser #1593

Merged
merged 2 commits into from Dec 16, 2017

Conversation

Projects
None yet
3 participants
@cquiroz
Member

cquiroz commented Dec 14, 2017

This PR starts from a change I want to do removing Registry from MediaRange. To do so I needed to generate MediaRange instances for scalacheck, which led me to create generators for various parts of the http spec previously untested.

This PR contains a test and the generators but there is one that is contentious and I'd like to get your comments

@cquiroz cquiroz added the RFC label Dec 14, 2017

Show outdated Hide outdated testing/src/main/scala/org/http4s/testing/ArbitraryInstances.scala Outdated
@cquiroz

This comment has been minimized.

Show comment
Hide comment
@cquiroz

cquiroz Dec 15, 2017

Member

I added a comment and a small fix for scala 2.11. It's probably a good idea to review the generators anyway

Member

cquiroz commented Dec 15, 2017

I added a comment and a small fix for scala 2.11. It's probably a good idea to review the generators anyway

@rossabaker

I want to get in here and rename the implicits according to standard, but this looks like it moves the ball forward.

@cquiroz

This comment has been minimized.

Show comment
Hide comment
@cquiroz

cquiroz Dec 15, 2017

Member

Which standard? I could rename them

Member

cquiroz commented Dec 15, 2017

Which standard? I could rename them

@rossabaker

This comment has been minimized.

Show comment
Hide comment
@rossabaker

rossabaker Dec 15, 2017

Member

This is how cats names them. I've been using http4s instead of catsPackageName as a unique-enough prefix.

Member

rossabaker commented Dec 15, 2017

This is how cats names them. I've been using http4s instead of catsPackageName as a unique-enough prefix.

@cquiroz

This comment has been minimized.

Show comment
Hide comment
@cquiroz

cquiroz Dec 15, 2017

Member

I see, I will switch the convention. Looking at the arbitraries you can see there have been many hands involved

Member

cquiroz commented Dec 15, 2017

I see, I will switch the convention. Looking at the arbitraries you can see there have been many hands involved

@cquiroz

This comment has been minimized.

Show comment
Hide comment
@cquiroz

cquiroz Dec 15, 2017

Member

Maybe it's better to do another PR with all arbitraries names fixed in on go. Shall I merge this one to get my another change as a PR?

Member

cquiroz commented Dec 15, 2017

Maybe it's better to do another PR with all arbitraries names fixed in on go. Shall I merge this one to get my another change as a PR?

@rossabaker rossabaker merged commit a3a74ee into http4s:master Dec 16, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rossabaker

This comment has been minimized.

Show comment
Hide comment
@rossabaker

rossabaker Dec 16, 2017

Member

Yes. :)

Member

rossabaker commented Dec 16, 2017

Yes. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment