Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add [openjdk11] to Travis build matrix #2105

Merged
merged 1 commit into from Sep 24, 2018
Merged

add [openjdk11] to Travis build matrix #2105

merged 1 commit into from Sep 24, 2018

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Sep 24, 2018

No description provided.

rossabaker
rossabaker approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 And then let's drop oraclejdk10 as soon as oraclejdk11 becomes official. But keep oraclejdk8 as the standard build, because that's still supported and what most of the world will continue to run on for a while.

@sullis
Copy link
Contributor Author

sullis commented Sep 24, 2018

Agreed!

cquiroz
cquiroz approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rossabaker rossabaker merged commit a504495 into http4s:master Sep 24, 2018
@rossabaker rossabaker mentioned this pull request Sep 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sullis @rossabaker @cquiroz