Record Metrics after client.run Resource has released
#2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrown1979
changed the title
client.run Resource has released
rossabaker
approved these changes
Nov 19, 2018
client/src/main/scala/org/http4s/client/middleware/Metrics.scala
Outdated
Show resolved
Hide resolved
|
@rossabaker Added a test that fails with the old code but passes with the new code. It's not very pretty, but it seems to do the job. If there's any improvements you see please let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with the
ClientMetricscode where we would decrement active requests and record total time before theResourcereturned from theclient.runwas actuallyreleased. This means our metrics were not accurate.The fix here is to perform both of these actions after the
client.runhas.released. To do so, both therecordTotalTimeand incr/decr of the active requests have been turned intoResources of their own, that.releaseafter theclient.run. This results in the behavior we expect. A test has been added to demonstrate the bug, and to show that it is now fixed.fixes #2282