Skip flaky blaze tests when running on CI #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
added
testing
ChristopherDavenport
approved these changes
Mar 20, 2019
rossabaker
added a commit
to http4s/http4s-servlet
that referenced
this pull request
Apr 3, 2022
…e-tests Skip flaky blaze tests when running on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm deeply reluctant to do this, but these tests have been failing intermittently in Travis for a long time, and never fail for me locally, and nobody has rolled up their sleeves and fixed them. These tests have negative value on CI.
Long term, we need to fix these tests, fix blaze, or build something better.