Change behaviour of Router to use segments #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the router to use segment routing instead of string prefix matching. The previous behaviour was unsafe and would match longer prefixes which may cause unexpected matches. This will no longer fallthrough on partial matches. * Add ContextRouter with same routing logic
rossabaker
approved these changes
Feb 1, 2020
There was a problem hiding this comment.
I remember being guided by the servlet specification with those rules, but looking again after all those years, I think what you did is right:
The container will recursively try to match the longest path-prefix. This is done
by stepping down the path tree a directory at a time, using the ’/’ character as a
path separator. The longest match determines the servlet selected
And whatever the servlet committee thinks, I think what you've done is more intuitive anyway.
hamnis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the router to use segment routing instead of string prefix matching.
The previous behaviour was unsafe and would match longer prefixes which may cause unexpected matches.
This will no longer fall-through on partial matches.