Fixes #4084 Port jetty to cats effect 3 #4191

ashwinbhaskar · 2021-01-12T05:29:14Z

No description provided.

ashwinbhaskar · 2021-01-12T05:31:11Z

@rossabaker The tests in JettyServerSuite all time out after 30 seconds and result in error. Where did I go wrong in that?

rossabaker · 2021-01-12T06:31:28Z

jetty/src/test/scala/org/http4s/server/jetty/Issue454.scala

 import org.eclipse.jetty.server.{HttpConfiguration, HttpConnectionFactory, Server, ServerConnector}
 import org.eclipse.jetty.servlet.{ServletContextHandler, ServletHolder}
 import org.http4s.dsl.io._
 import org.http4s.servlet.AsyncHttp4sServlet
 import org.http4s.syntax.all._

 object Issue454 {
-  implicit val cs: ContextShift[IO] = Http4sSpec.TestContextShift
+  // implicit val cs: ContextShift[IO] = Http4sSpec.TestContextShift


This code doesn't ever run as part of the build. If we can't figure out a way to automate it, then I think it's ready to be removed.

jetty/src/test/scala/org/http4s/server/jetty/JettyServerSuite.scala

rossabaker · 2021-01-12T06:31:28Z

jetty/src/main/scala/org/http4s/server/jetty/JettyBuilder.scala

@@ -224,7 +233,8 @@ sealed class JettyBuilder[F[_]] private (
        service = service,
        asyncTimeout = builder.asyncTimeout,
        servletIo = builder.servletIo,
-        serviceErrorHandler = builder.serviceErrorHandler
+        serviceErrorHandler = builder.serviceErrorHandler,
+        dispatcher


Some other backends are creating dispatcher in Resource, which is a pattern I like. The challenge would be how you can thread it down to here.

are you suggesting to pass Resource[IO,Dispatcher[IO]] instead of Dispatcher[IO] ?

No, I'm saying to let one of the functions in this create it. In BlazeClientBuilder (yes, that's a client, and this is a server, but... almost the same), we're creating and using a dispatcher resource in the .resource function. Can we do that here?

I think if the function in the Mount class took a Dispatcher, the rest of it would fall into place, and you could remove the Dispatcher as a parameter of the builder.

got it, let me try that

@rossabaker the resource method returns a Resource with type parameter F. That means we should have a Dispatcher[F] in scope. We can change the signature of def resource: Resource[F, Server] to def resource(dispatcher: Dispatcher[F]): Resource[F, Server]. But this would mean changing the signature on the trait ServerBuilder.
If we want to avoid this, then we would have to pass a dispatcher to the builder.

Oh, I was thinking that resource would create a Dispatcher resource and flatMap it. BlazeClientBuilder does it like this:

def resource: Resource[F, Client[F]] = for { dispatcher <- Dispatcher[F] ... } yield ...

@rossabaker my bad. You are right. Having an implicit Async[F] brings Dispatcher[F] in scope

rossabaker · 2021-01-13T04:36:13Z

Are we past the timeout problem now?

ashwinbhaskar · 2021-01-13T04:55:58Z

Are we past the timeout problem now?

@rossabaker no, the timeout issue still persists.

rossabaker · 2021-01-13T05:10:37Z

Oh, the module just isn't enabled yet. I didn't see the failing test and was hoping we were through it. Do you have any ideas yet or do you need some help?

ashwinbhaskar · 2021-01-13T05:12:41Z

Oh, the module just isn't enabled yet. I didn't see the failing test and was hoping we were through it. Do you have any ideas yet or do you need some help?

I am still trying to figure out the issue. Any help is welcome:)
I am also skeptical of the changes made in Issue454.scala. I think the dispatcher will be shutdown well AsyncHttp4sServlet gets a change to use it?

rossabaker · 2021-01-13T05:16:54Z

Oh, I thought we were deleting Issue454 entirely since it isn't a test that gets run.

ashwinbhaskar · 2021-01-13T05:28:35Z

Oh, I thought we were deleting Issue454 entirely since it isn't a test that gets run.

okay, I understood it as deleting the implicit line 😅
Will delete it:)

ashwinbhaskar · 2021-01-13T06:17:10Z

Added some log statements. It confirms this line is causing the timeout.

rossabaker · 2021-01-13T06:24:43Z

Try unsafeRunAndForget instead of unsafeRunSync.

ashwinbhaskar · 2021-01-13T06:26:14Z

Try unsafeRunAndForget instead of unsafeRunSync.

results in IOException: Server returned HTTP response code: 503..

ashwinbhaskar · 2021-01-13T09:05:24Z

@rossabaker The issue was in servlet module. async_ has signature k: (Either[Throwable, A] => Unit) => Unit): F[A] but Deferred's complete was returning an F[Boolean].

m-sp · 2021-01-13T20:05:57Z

servlet/src/main/scala/org/http4s/servlet/AsyncHttp4sServlet.scala

@@ -82,7 +82,8 @@ class AsyncHttp4sServlet[F[_]](

      val timeout =
        F.async_[Response[F]] { cb =>
-          val _ = gate.complete(ctx.addListener(new AsyncTimeoutHandler(cb)))
+          val _ =
+            dispatcher.unsafeRunSync(gate.complete(ctx.addListener(new AsyncTimeoutHandler(cb))))


no need to block here you should be able to just do

F.async[Response[F]] { cb => gate.complete(ctx.addListener(new AsyncTimeoutHandler(cb))).as(Option.empty[F[Unit]]) }

rossabaker

🎉

Fixes http4s/http4s#4084 Port jetty to cats effect 3

ashwinbhaskar requested a review from rossabaker January 12, 2021 05:31

rossabaker reviewed Jan 12, 2021

View reviewed changes

Fixes #4084 Port jetty to cats effect 3

2f8f492

Create Dispatcher resource within resource method

c046966

rossabaker added this to To do in Cats Effect 3 via automation Jan 13, 2021

Remove unused object Issue454

97cabc8

ashwinbhaskar added 3 commits January 13, 2021 11:57

Enable jetty module

d3ee4be

Enable Servlet Module

7a21c82

Fix timeout

628b919

ashwinbhaskar changed the title ~~WIP Fixes #4084 Port jetty to cats effect 3~~ Fixes #4084 Port jetty to cats effect 3 Jan 13, 2021

Remove deprecated method eval_

2c182f5

m-sp reviewed Jan 13, 2021

View reviewed changes

Use async instead of async_ and remove blocking call

760dd38

rossabaker approved these changes Jan 16, 2021

View reviewed changes

rossabaker merged commit 0e0f74b into http4s:main Jan 16, 2021

Cats Effect 3 automation moved this from To do to Done Jan 16, 2021

rossabaker added a commit to http4s/http4s-servlet that referenced this pull request Apr 3, 2022

Merge pull request http4s/http4s#4191 from ashwinbhaskar/port_jetty

0bf404b

Fixes http4s/http4s#4084 Port jetty to cats effect 3

rossabaker added a commit to http4s/http4s-servlet that referenced this pull request Apr 4, 2022

Merge pull request http4s/http4s#4191 from ashwinbhaskar/port_jetty

40c30f2

Fixes http4s/http4s#4084 Port jetty to cats effect 3

Fixes #4084 Port jetty to cats effect 3 #4191

Fixes #4084 Port jetty to cats effect 3 #4191

ashwinbhaskar commented Jan 12, 2021

ashwinbhaskar commented Jan 12, 2021

rossabaker Jan 12, 2021

ashwinbhaskar Jan 12, 2021

rossabaker Jan 12, 2021

ashwinbhaskar Jan 12, 2021 •

edited

rossabaker Jan 12, 2021

ashwinbhaskar Jan 13, 2021

ashwinbhaskar Jan 13, 2021 •

edited

rossabaker Jan 13, 2021

ashwinbhaskar Jan 13, 2021

rossabaker commented Jan 13, 2021

ashwinbhaskar commented Jan 13, 2021

rossabaker commented Jan 13, 2021

ashwinbhaskar commented Jan 13, 2021

rossabaker commented Jan 13, 2021

ashwinbhaskar commented Jan 13, 2021

ashwinbhaskar commented Jan 13, 2021

rossabaker commented Jan 13, 2021

ashwinbhaskar commented Jan 13, 2021 •

edited

ashwinbhaskar commented Jan 13, 2021

m-sp Jan 13, 2021

rossabaker left a comment

Fixes #4084 Port jetty to cats effect 3 #4191

Fixes #4084 Port jetty to cats effect 3 #4191

Conversation

ashwinbhaskar commented Jan 12, 2021

ashwinbhaskar commented Jan 12, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashwinbhaskar Jan 12, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashwinbhaskar Jan 13, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rossabaker commented Jan 13, 2021

ashwinbhaskar commented Jan 13, 2021

rossabaker commented Jan 13, 2021

ashwinbhaskar commented Jan 13, 2021

rossabaker commented Jan 13, 2021

ashwinbhaskar commented Jan 13, 2021

ashwinbhaskar commented Jan 13, 2021

rossabaker commented Jan 13, 2021

ashwinbhaskar commented Jan 13, 2021 • edited

ashwinbhaskar commented Jan 13, 2021

Choose a reason for hiding this comment

rossabaker left a comment

Choose a reason for hiding this comment

ashwinbhaskar Jan 12, 2021 •

edited

ashwinbhaskar Jan 13, 2021 •

edited

ashwinbhaskar commented Jan 13, 2021 •

edited