Distinguish between reserved and unknown frame opcodes #4753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasilmkd
commented
Apr 17, 2021
blaze-core/src/main/scala/org/http4s/blazecore/websocket/Http4sWSStage.scala
Outdated
Show resolved
Hide resolved
vasilmkd
commented
Apr 17, 2021
blaze-server/src/main/scala/org/http4s/server/blaze/WebSocketDecoder.scala
Show resolved
Hide resolved
rossabaker
reviewed
Apr 18, 2021
blaze-core/src/main/scala/org/http4s/blazecore/websocket/Http4sWSStage.scala
Outdated
Show resolved
Hide resolved
blaze-server/src/main/scala/org/http4s/server/blaze/WebSocketDecoder.scala
Show resolved
Hide resolved
rossabaker
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves http4s/blaze#669.
Opening as a draft because I would like an initial review and some pointers on how (or if) to test this. I've only made changes to
coreandblaze-server. Do any of the other backends need adjusting?