Add try/catch arounds reset timeout so we dont blow up on shutdown #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be enhanced by including: http4s/blaze#535
rossabaker
reviewed
May 26, 2021
blaze-core/src/main/scala/org/http4s/blazecore/IdleTimeoutStage.scala
Outdated
Show resolved
Hide resolved
hamnis
commented
May 26, 2021
| try setAndCancel(exec.schedule(killSwitch, ec, timeout)) | ||
| catch { | ||
| case TickWheelExecutor.AlreadyShutdownException => | ||
| logger.warn(s"Resetting timeout after tickwheelexecutor is shutdown") |
There was a problem hiding this comment.
How frequent is the error still? It still indicates something is broken. It seems like a good warning to me.
ChristopherDavenport
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be enhanced by including: http4s/blaze#535