Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand docs on client middlewares #5416

Merged
merged 4 commits into from
Oct 20, 2021

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented Oct 19, 2021

No description provided.

@armanbilge
Copy link
Member

armanbilge commented Oct 19, 2021

Not sure how tricky a merge would be, but you may want to base against #5313. Scratch that, probably will be fine 👍

@kubukoz
Copy link
Contributor Author

kubukoz commented Oct 19, 2021

Yeah @armanbilge, it's probably going to be fine :)

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@rossabaker rossabaker merged commit 420b79b into http4s:series/0.23 Oct 20, 2021
@kubukoz
Copy link
Contributor Author

kubukoz commented Oct 20, 2021

Do we want this backported to other branches? Let me know how I can help with that. Not sure if it can help but Mergify in the free tier is capable of creating backport PRs: https://mergify.io/pricing

@rossabaker
Copy link
Member

0.22 is still officially maintained, so that's a nice bonus. It might cherry pick nicely. I don't know how many CE3-isms it has.

I didn't know mergify did backports. We usually merge forward, so I'm not sure how helpful that is, but it's also worth a glance.

@kubukoz
Copy link
Contributor Author

kubukoz commented Oct 20, 2021

There's MonadCancelThrow and that's probably just it. I'll send a backport to series/0.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants