Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update discipline-core to 1.2.0 in series/0.22 #5418

Conversation

scala-steward
Copy link
Contributor

Updates org.typelevel:discipline-core from 1.1.5 to 1.2.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (1.1.5).
You might want to review and update them manually.

core/src/main/scala/org/http4s/headers/Content-Type.scala
website/src/hugo/content/changelog.md
Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.typelevel", artifactId = "discipline-core" } ]

labels: library-update, semver-minor, old-version-remains

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see the expert consensus on typelevel/cats#4018, but I think what discipline does with its Scala.js is of no consequence to us. Probably yes on this.

@armanbilge
Copy link
Member

armanbilge commented Oct 20, 2021

Yeah, the ship has almost definitely sailed on this already since we're already on SJS 1.7.x. For us to rollback to 1.5.x like cats (if this is even possible!) would require rolling back tons of projects, including CE3, fs2, scala-js-macrotask-executor, ..., and not updating discipline.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if a rollback by us is not both safe and isolated, there's no reason to hold this back.

@rossabaker rossabaker merged commit ec04570 into http4s:series/0.22 Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants