Use an instance of Arbitrary[Year] from ScalaCheck
#5577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
approved these changes
Nov 13, 2021
There was a problem hiding this comment.
Btw, all of these date/time instances are only in ScalaCheck for JVM. I started a PR to add them for JS as well but the problem is that it creates a circular dependency. Update: I looked back at my scalacheck PR and I think we can do it without the circular dependency :)
|
If they're only on the JVM, what is this going to do when we merge it to CE3? |
|
These tests have been JVM-only on series/0.23 and main b/c of this. But hopefully we can fix that with the next scalacheck release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A custom instance is not needed anymore.