Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #6068 digestauth challenge redux #6138

Merged
merged 37 commits into from
Mar 24, 2022
Merged

Resolve #6068 digestauth challenge redux #6138

merged 37 commits into from
Mar 24, 2022

Commits on Mar 21, 2022

  1. Exposing callable parameters for DigestAuth.challenge 

    Resolves http4s#6068

NonceKeeper is package-private, so there's no way to construct one,
meaning there's no way to call `challenge`.

Mirror the same parameters from `apply`, and maintain the previous
`challenge` method for bincompat.
    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    a34ffa6 View commit details
    Browse the repository at this point in the history

  2. Update server/src/main/scala/org/http4s/server/middleware/authenticat… 

    …ion/DigestAuth.scala

Co-authored-by: Arman Bilge <armanbilge@gmail.com>
    @blast-hardcheese @armanbilge
    blast-hardcheese and armanbilge committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    4ee881c View commit details
    Browse the repository at this point in the history

  3. Embedding new NonceKeeper in F.delay

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    1cbfe59 View commit details
    Browse the repository at this point in the history

  4. Chasing F.delay for NonceKeeper 

    In order to achieve the goal of F.delay(new NonceKeeper) but maintaining
the original intent of `apply`, just revert everything in this PR, make
the original (unusable) `challenge` `private`, and create a new public
`challenge` with the necessary parameters, intended for human use,
without impacting the existing flow.
    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    b645a3b View commit details
    Browse the repository at this point in the history

  5. Update server/src/main/scala/org/http4s/server/middleware/authenticat… 

    …ion/DigestAuth.scala

Co-authored-by: Arman Bilge <armanbilge@gmail.com>
    @blast-hardcheese @armanbilge
    blast-hardcheese and armanbilge committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    98a1dcb View commit details
    Browse the repository at this point in the history

  6. quicklint

    @blast-hardcheese
    Devon Stewart authored and blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    8196978 View commit details
    Browse the repository at this point in the history

  7. Promote DigestAuth.apply to F[_] 

    Internals unchanged, in preparation for a pure rewrite of DigestAuth.

Includes a private bincompat method
    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    4819197 View commit details
    Browse the repository at this point in the history

  8. Switching AuthenticationSuite to use DigestAuth.applyF

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    7a60bd1 View commit details
    Browse the repository at this point in the history

  9. First pass of overhauling NonceKeeper with Ref and Semaphore

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    db00ac4 View commit details
    Browse the repository at this point in the history

  10. Remove return

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    7163a30 View commit details
    Browse the repository at this point in the history

  11. Promote DigestAuth.apply to F[_] 

    Internals unchanged, in preparation for a pure rewrite of DigestAuth.

Includes a private bincompat method
    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    e50b67b View commit details
    Browse the repository at this point in the history

  12. Break out NonceKeeperF

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    f5ff20b View commit details
    Browse the repository at this point in the history

  13. Switch to NonceKeeperF

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    a4054ee View commit details
    Browse the repository at this point in the history

  14. Break out Nonce

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    46c68a6 View commit details
    Browse the repository at this point in the history

  15. Switch to NonceF

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    8a2c072 View commit details
    Browse the repository at this point in the history

  16. bincompat

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    c57ae72 View commit details
    Browse the repository at this point in the history

  17. tailrec -> tailRecM

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    b5283e6 View commit details
    Browse the repository at this point in the history

  18. Flesh out AuthenticationStore

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    5c7f4d9 View commit details
    Browse the repository at this point in the history

  19. Bumping deprecated version number

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    d241359 View commit details
    Browse the repository at this point in the history

  20. getRandomData should be F-suspended

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    5fe1648 View commit details
    Browse the repository at this point in the history

  21. Strike fear into the hearts of men

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    0ad0342 View commit details
    Browse the repository at this point in the history

  22. Moving nonces into NonceKeeperF constructor

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    f702b42 View commit details
    Browse the repository at this point in the history

  23. F-suspend getRandomData

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    c69302c View commit details
    Browse the repository at this point in the history

  24. Documentation

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    b748965 View commit details
    Browse the repository at this point in the history

  25. Preparing for more secure authStore test

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    4345b53 View commit details
    Browse the repository at this point in the history

  26. Adding a test for Md5HashedAuthenticationStore

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    645d2da View commit details
    Browse the repository at this point in the history

  27. De-case-ize AuthenticationStore members

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    3122229 View commit details
    Browse the repository at this point in the history

  28. Renaming AuthenticationStore to AuthStore

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    aa6ab18 View commit details
    Browse the repository at this point in the history

  29. Adding Md5HashedAuthStore.precomputeHash helper

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    61bcac3 View commit details
    Browse the repository at this point in the history

  30. Swapping ju.Date to Instant

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    8c6ef83 View commit details
    Browse the repository at this point in the history

  31. Switching from Instant and realTime to monotonic millis

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    35dbb6e View commit details
    Browse the repository at this point in the history

  32. Swapping out Long to Duration

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    4a5f76e View commit details
    Browse the repository at this point in the history

  33. Wiring through Blocking and ContextShift for http4s#6165 

    In preparation for http4s#6165, thread
through the required instances so we can just swap out `SecureRandom`
when that stuff becomes available.
    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    a31c5d6 View commit details
    Browse the repository at this point in the history

  34. uri: String -> Uri

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    f84f759 View commit details
    Browse the repository at this point in the history

  35. bincompat

    @blast-hardcheese
    blast-hardcheese committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    733dcf7 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Stub out Blocker since this is all just going away in CE3 anyway 

    We're already behind a Semaphore, and this Blocker instance is just to satisfy http4s#6165.

Use the Blocker constructor available on both JVM and JS
    @blast-hardcheese
    blast-hardcheese committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    e028cf5 View commit details
    Browse the repository at this point in the history

  2. Push Blocker out to the user's control

    @blast-hardcheese
    blast-hardcheese committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    11ef78b View commit details
    Browse the repository at this point in the history