Address the entity model in the Client#fromHttpApp
#6325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
approved these changes
Apr 25, 2022
|
@rossabaker Yeah, I was thinking about this too. The current implementation is using a single Ref within checking/processing bodies of request and response. Basically, it's a matrix 2x2, and there is only one case where we won't create Ref. Probably, it's worth pushing forward, but I'm happy if we can do it iteratively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for annoying with that kind of PRs, but I believe they bring some performance enhancements. Though I don't give the numbers to support my points, it just goes from common sense and looks natural.