0.23 -> main #6551

armanbilge · 2022-07-20T06:24:41Z

No conflicts.

Each method takes a FrameTranscoder as parameter, but it is always the non-client one, so we can extract it as a constant.

EncodeFrames was just a pipe to do a flatMap. We extract the function of flatMap as `encodeFrame`. We also replace some calls to `through(encodeFrames)` with a flatMap call.

We replace the `through handleIncomingFrames` parts with just calls to `.evalMapFilter`. We extract from `handleIncomingFrames` the inner function to optional.

It could be to Option, but somehow Option is not Seq.

Before commit, `encodeFrame` takes a frame and generate a stream of bytes, which is then immediately processed chunk by chunk. Instead, we can by-pass the stream phase, leave the chunks in a list, and use a `traverse_`.

…touches Ember-Server: WebSocketHelper rewrite / optimisation

fix typo in `Throttle` middleware `httpAapp->httpApp`

…-minimal-en_us-db-1.4.1 Update locales-minimal-en_us-db to 1.4.1 in series/0.23

…fect-3.3.13 Update cats-effect, cats-effect-std, ... to 3.3.13 in series/0.23

…e-3.2.9 Update fs2-core, fs2-io to 3.2.9 in series/0.23

Create `.git-blame-ignore-revs`

Custom branch for update flake action

Update sbt to 1.7.1 in series/0.23

…uffer-4.1.79.Final Update netty-buffer, netty-codec-http to 4.1.79.Final in series/0.23

Completely my bad, the changes in http4s#6498 needed the action to be updated to latest 😅

…fect-3.3.14 Update cats-effect, cats-effect-std, ... to 3.3.14 in series/0.23

…s-core-2.4.0 Update log4cats-core, log4cats-noop, ... to 2.4.0 in series/0.23

Update to update-flake-lock v10

Add Hireproof to adopters

Executed command: sbt tlPrePrBotHook

…p4s-org-0.14.4 Update sbt-http4s-org to 0.14.4 in series/0.23

Flake lock file updates: • Updated input 'typelevel-nix': 'github:rossabaker/typelevel-nix/a183dd87238be83478fdca8a35b05dbcf57e96f8' (2022-07-04) → 'github:rossabaker/typelevel-nix/2d2b118d056b851dea9ccb0775ddd5ce8a1dbd79' (2022-07-18) • Updated input 'typelevel-nix/flake-utils': 'github:numtide/flake-utils/bee6a7250dd1b01844a2de7e02e4df7d8a0a206c' (2022-06-24) → 'github:numtide/flake-utils/7e2a3b3dfd9af950a856d66b0a7d01e3c18aa249' (2022-07-04) • Updated input 'typelevel-nix/nixpkgs': 'github:nixos/nixpkgs/660ac43ff9ab1f12e28bfb31d4719795777fe152' (2022-07-02) → 'github:nixos/nixpkgs/78e748fa68079b77ac055c80ef21342dd7e2ae2b' (2022-07-17)

flake.lock: Update

Remove references to `HttpService` in `testing.md`

danicheg · 2022-07-20T07:53:13Z

server/shared/src/main/scala/org/http4s/server/middleware/Throttle.scala

@@ -129,9 +129,14 @@ object Throttle {
      Throttle.httpRoutes(bucket, defaultResponse[F] _)(httpRoutes)
    )

+  @deprecated("Use httpApp instead.", "0.23.14")
+  def httpAapp[F[_]](amount: Int, per: FiniteDuration)(httpApp: HttpApp[F])(implicit


I think we can remove this

Maybe we should give once cycle of deprecation, to help migration?

🤷🏻 Can't suggest how many users might be affected by just removing this, but this was introduced weeks ago

Oh, I didn't realize it was so recent. I guess it was in M33 and M34.

httpRoutes and httpApp shortcuts for Throttle middleware #6365

I don't mind if we release this with deprecation and then remove it. Just we definitely have to remove it for 1.0 :)

diesalbla and others added 30 commits June 23, 2022 19:08

Extract the FrameTranscoder as a constant.

1f2ef5d

Each method takes a FrameTranscoder as parameter, but it is always the non-client one, so we can extract it as a constant.

EncodeFrames: reduce to encode single frame

4c21429

EncodeFrames was just a pipe to do a flatMap. We extract the function of flatMap as `encodeFrame`. We also replace some calls to `through(encodeFrames)` with a flatMap call.

Reduce handleIncomingFrames to single frame

b69bd34

We replace the `through handleIncomingFrames` parts with just calls to `.evalMapFilter`. We extract from `handleIncomingFrames` the inner function to optional.

Small change: simplify Stream to List.

e39a0e1

It could be to Option, but somehow Option is not Seq.

Fuse encodeFrame and write into a writeFrame method.

09d8100

Before commit, `encodeFrame` takes a frame and generate a stream of bytes, which is then immediately processed chunk by chunk. Instead, we can by-pass the stream phase, leave the chunks in a list, and use a `traverse_`.

Extract sendClosingFrame.

a05da49

[ci skip] Custom branch for update flake action

13ca3f1

Merge pull request http4s#6388 from diesalbla/ember-server-websocket-…

a424ddf

…touches Ember-Server: WebSocketHelper rewrite / optimisation

fix typo in Throttle middleware httpAapp->httpApp

a26b237

Update locales-minimal-en_us-db to 1.4.1 in series/0.23

1bbd8b5

Merge pull request http4s#6501 from jbwheatley/Throttle-httpApp-typo

3c0e866

fix typo in `Throttle` middleware `httpAapp->httpApp`

Merge pull request http4s#6502 from http4s/update/series/0.23/locales…

403b2fd

…-minimal-en_us-db-1.4.1 Update locales-minimal-en_us-db to 1.4.1 in series/0.23

Update cats-effect, cats-effect-std, ... to 3.3.13 in series/0.23

eeacaf2

Merge pull request http4s#6503 from http4s/update/series/0.23/cats-ef…

3cd508c

…fect-3.3.13 Update cats-effect, cats-effect-std, ... to 3.3.13 in series/0.23

Update fs2-core, fs2-io to 3.2.9 in series/0.23

6447c1b

Merge pull request http4s#6505 from http4s/update/series/0.23/fs2-cor…

12ba8ee

…e-3.2.9 Update fs2-core, fs2-io to 3.2.9 in series/0.23

[ci skip] Create .git-blame-ignore-revs

2af1556

[ci skip] add another fmt commit

975e674

[ci skip] fix wrong comment

aeedbb7

Merge pull request http4s#6506 from http4s/git-blame-ignore-revs

a64f931

Create `.git-blame-ignore-revs`

Merge pull request http4s#6498 from http4s/pr/custom-update-flake-branch

2969f82

Custom branch for update flake action

Smite Seq in OAuthSuite

aea2964

Smite Seq in ChunkAggregatorSuite

4ec287e

Smite Seq in FileServiceSuite

ac0359e

Smite Seq in UriSpec

c2a7988

Smite Seq in UrlFormSpec

5c27c0a

Smite Seq in ForwardedSuite

0ea9223

Smite Seq in MultipartParserSuite

29684a6

Smite Seq in AcceptHeaderSpec

62fcb57

Smite Seq in AuthorizationHeaderSuite

43dc1c0

http4s-steward bot and others added 21 commits July 12, 2022 02:28

Update netty-buffer, netty-codec-http to 4.1.79.Final in series/0.23

2940c36

Update sbt to 1.7.1 in series/0.23

39a3a57

Merge pull request http4s#6530 from http4s/update/series/0.23/sbt-1.7.1

526dfd6

Update sbt to 1.7.1 in series/0.23

Merge pull request http4s#6529 from http4s/update/series/0.23/netty-b…

f641a93

…uffer-4.1.79.Final Update netty-buffer, netty-codec-http to 4.1.79.Final in series/0.23

[ci skip] Update to update-flake-lock v10

19dcc26

Completely my bad, the changes in http4s#6498 needed the action to be updated to latest 😅

Update cats-effect, cats-effect-std, ... to 3.3.14 in series/0.23

e5b013d

Merge pull request http4s#6532 from http4s/update/series/0.23/cats-ef…

14a100a

…fect-3.3.14 Update cats-effect, cats-effect-std, ... to 3.3.14 in series/0.23

Update log4cats-core, log4cats-noop, ... to 2.4.0 in series/0.23

764959c

Merge pull request http4s#6534 from http4s/update/series/0.23/log4cat…

e032c53

…s-core-2.4.0 Update log4cats-core, log4cats-noop, ... to 2.4.0 in series/0.23

Merge pull request http4s#6531 from http4s/update/update-flake-lock-v10

6b10401

Update to update-flake-lock v10

Add Hireproof to adopters

bf445a9

Merge pull request http4s#6536 from taig/patch-1

9fb3a56

Add Hireproof to adopters

Update sbt-http4s-org to 0.14.4 in series/0.23

b2b4158

Run prePR with sbt-typelevel

3b87c41

Executed command: sbt tlPrePrBotHook

Merge pull request http4s#6537 from http4s/update/series/0.23/sbt-htt…

bb7ee1e

…p4s-org-0.14.4 Update sbt-http4s-org to 0.14.4 in series/0.23

Merge pull request http4s#6546 from http4s/update/flake-lock-8

9fabeef

flake.lock: Update

Remove references to HttpService in testing.md

337ddee

Merge pull request http4s#6548 from danicheg/testing.md

62bbf96

Remove references to `HttpService` in `testing.md`

Merge branch 'series/0.23'

ebf3cb6

Fix compile

da5d684

armanbilge added the behind-the-scenes Appreciated, but not user-facing label Jul 20, 2022

mergify bot added module:server module:client module:ember-core module:ember-server docs Relates to our website or tutorials labels Jul 20, 2022

danicheg approved these changes Jul 20, 2022

View reviewed changes

ChristopherDavenport approved these changes Jul 23, 2022

View reviewed changes

armanbilge merged commit 0fe77b8 into http4s:main Jul 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

0.23 -> main #6551

0.23 -> main #6551

armanbilge commented Jul 20, 2022

danicheg Jul 20, 2022

armanbilge Jul 20, 2022

danicheg Jul 20, 2022

armanbilge Jul 20, 2022

danicheg Jul 20, 2022

0.23 -> main #6551

0.23 -> main #6551

Conversation

armanbilge commented Jul 20, 2022

danicheg Jul 20, 2022

Choose a reason for hiding this comment

armanbilge Jul 20, 2022

Choose a reason for hiding this comment

danicheg Jul 20, 2022

Choose a reason for hiding this comment

armanbilge Jul 20, 2022

Choose a reason for hiding this comment

danicheg Jul 20, 2022

Choose a reason for hiding this comment