Update to munit 1.0.0-M6 #6657
Merged
Update to munit 1.0.0-M6 #6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicheg
approved these changes
Sep 9, 2022
|
This is a published dependency, via laws. The laws are underdeveloped, rarely depended on, and would not typically be used in applications, so it's not tragic. But this was a breaking change in a patch, and now production depends on a milestone. |
|
Sorry, I was completely unaware of that. Why do our laws depend on munit? Typically laws depend on Discipline and not a specific test framework. |
|
Good question. Looks like |
|
Hmm. At a glance I think the Right:tm: thing to do there would have been to use the Cats Effect testkit. Not ruling out that effectful laws are tricky. We can fix this on 1.x. |
This was referenced Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point it is quite stable and brings many improvements we could benefit from, such as async resource fixtures (thanks to @danicheg for working on that in munit core :)