Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown#trackConnection should never be empty #6781

Merged
merged 2 commits into from Nov 1, 2022
Merged

Shutdown#trackConnection should never be empty #6781

merged 2 commits into from Nov 1, 2022

Conversation

armanbilge
Copy link
Member

Fixes #6780.

armanbilge
armanbilge commented Oct 31, 2022
View reviewed changes
ember-server/shared/src/main/scala/org/http4s/ember/server/internal/Shutdown.scala
override val trackConnection: Stream[F, Unit] = Stream.empty
override val trackConnection: Stream[F, Unit] = Stream.emit(())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the next FS2 release this can be Stream.unit.

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:ember-server labels Oct 31, 2022
@armanbilge armanbilge merged commit 36372fe into http4s:series/0.23 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubukoz kubukoz kubukoz approved these changes

@ChristopherDavenport ChristopherDavenport ChristopherDavenport approved these changes

Assignees
No one assigned
Labels
module:ember-server series/0.23 PRs targeting 0.23.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ember server: Empty shutdown timeout causes "connection reset by peer" on all requests
3 participants
@armanbilge @kubukoz @ChristopherDavenport