Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for 6851 : Uri.Path.Segment can throw from its equals method #6853

Merged
merged 1 commit into from Dec 6, 2022
Merged

Fix for 6851 : Uri.Path.Segment can throw from its equals method #6853

merged 1 commit into from Dec 6, 2022

Conversation

mattyjbrown
Copy link
Contributor

Let me know if I've picked the wrong place for the test!

@mattyjbrown mattyjbrown changed the title Fix for https://github.com/http4s/http4s/issues/6851 : Uri.Path.Segment can throw from its equals method Fix for 6851 : Uri.Path.Segment can throw from its equals method Dec 6, 2022
@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:core labels Dec 6, 2022
bplommer
bplommer approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@bplommer bplommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this needs a test?

@mattyjbrown mattyjbrown mentioned this pull request Dec 6, 2022
Closed
@mattyjbrown
Copy link
Contributor Author

Not sure if this needs a test?

Yeah I can see that POV, but I came down on the side of "you should add a test for bugs you fix" 🤷‍♂️

danicheg
danicheg approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

hamnis
hamnis approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@hamnis hamnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch

@danicheg danicheg merged commit 2c034f6 into http4s:series/0.23 Dec 6, 2022
@armanbilge armanbilge linked an issue Dec 6, 2022 that may be closed by this pull request
Uri.Path.Segment.equals throws a MatchError when passed a parameter of another type #6851
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamnis hamnis hamnis approved these changes

@bplommer bplommer bplommer approved these changes

@danicheg danicheg danicheg approved these changes

Assignees
No one assigned
Labels
module:core series/0.23 PRs targeting 0.23.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uri.Path.Segment.equals throws a MatchError when passed a parameter of another type
4 participants
@mattyjbrown @hamnis @bplommer @danicheg