Don't drain the body for non-streamed entities in EmberClient

[danicheg]

No description provided.

[armanbilge]

Thanks, good catch :)

[valencik]

Just to double check my understanding, this is a small performance optimization not a correctness / bug fix, right?

In the case of empty or strict entities we don't need to worry about draining all the bytes from the underlying stream because they are already all in memory, we don't have the risk of leaving some bytes from the socket unread?

[armanbilge]

In the case of empty or strict entities we don't need to worry about draining all the bytes from the underlying stream because they are already all in memory

Exactly.

http4s/core/shared/src/main/scala/org/http4s/Entity.scala

Lines 60 to 61 in 54bec99

	final case class Strict(bytes: ByteVector) extends Entity[Pure] {
	def body: EntityBody[Pure] = Stream.chunk(Chunk.byteVector(bytes))

[valencik]

The readability here will be super nice when/if #6305 merges 😎