New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge series/0.23
into main
#7025
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a special case error handler to be executed when the request-line, e.g. "GET / HTTP/1.1", it not able to be parsed. This is a different case than the more general error handler we already have. RFC 7230 states a server should return either 400 or 301. The handler is configurable, but the default is to return a 301 Closes http4s#6931
…ase-handle-request-line-parse-failure
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
…uffer-4.1.88.Final Update netty-buffer, netty-codec-http to 4.1.88.Final in series/0.23
…uffer-4.1.89.Final Update netty-buffer, netty-codec-http to 4.1.89.Final in series/0.23
…ive-packager-1.9.15 Update sbt-native-packager to 1.9.15 in series/0.23
Flake lock file updates: • Updated input 'typelevel-nix': 'github:typelevel/typelevel-nix/84deba77d4f4a758f37ef09dcb4820bb9374aa54' (2023-01-16) → 'github:typelevel/typelevel-nix/93f0aed9407ae0e9e215e995e62794ad60d715da' (2023-02-09) • Updated input 'typelevel-nix/devshell': 'github:numtide/devshell/5aa3a8039c68b4bf869327446590f4cdf90bb634' (2022-12-19) → 'github:numtide/devshell/2e19b92980a79118351ec12496a81c49bd674d8a' (2023-02-02) • Updated input 'typelevel-nix/nixpkgs': 'github:nixos/nixpkgs/37b97ae3dd714de9a17923d004a2c5b5543dfa6d' (2023-01-13) → 'github:nixos/nixpkgs/d840126a0890621e7b220894d749132dd4bde6a0' (2023-02-05)
flake.lock: Update
…fect-3.4.7 Update cats-effect, cats-effect-std, ... to 3.4.7 in series/0.23
Add section with sbt dependencies to quickstart
flake.lock: Update
…uffer-4.1.90.Final Update netty-buffer, netty-codec-http to 4.1.90.Final in series/0.23
Detect terminated `EmberConnection`s in ember client prior to attempting a request
…rsWithoutTrailerHeader All received messages in h2 could have trailers
Redirect `H2Connection.writeLoop` errors to logger
…e-request-line-parse-failure Special Case Error Handler For Unparsable Request Line
mergify
bot
added
module:core
module:laws
module:server
module:client
module:ember-core
module:ember-server
module:ember-client
module:circe
docs
Relates to our website or tutorials
labels
Mar 15, 2023
Release v0.23.19-RC3
Merged
armanbilge
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there were no major conflicts? I'm amazed tbh 😅
Thanks for doing this 🙏
client/jvm/src/main/scala/org/http4s/client/JavaNetClientBuilder.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
@armanbilge Actually, there were about 5-6 files to look into due to merge conflicts. So yeah, that one was quite low-hanging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
behind-the-scenes
Appreciated, but not user-facing
docs
Relates to our website or tutorials
module:circe
module:client
module:core
module:ember-client
module:ember-core
module:ember-server
module:laws
module:server
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.