Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up internal package #7030

Merged
merged 2 commits into from Mar 20, 2023
Merged

Clean up internal package #7030

merged 2 commits into from Mar 20, 2023

Conversation

danicheg
Copy link
Member

A follow-up PR after refactoring in 0.23.

@mergify mergify bot added the module:core label Mar 18, 2023
armanbilge
armanbilge approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🎉

Can also remove this one?

http4s/core/shared/src/main/scala/org/http4s/internal/package.scala

Lines 97 to 98 in e6b853b

@deprecated("Use fs2.text.decodeWithCharset", "0.23.5")
def decode[F[_]: RaiseThrowable](charset: Charset): Pipe[F, Byte, String] = { in =>

core/shared/src/main/scala/org/http4s/internal/package.scala Outdated
case HexDecodeException => None
}
}

private[http4s] def fromCompletionStage[F[_], CF[x] <: CompletionStage[x], A](fcs: F[CF[A]])(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to remove this too. Can't find if anyone is using it, and now we have fromCompletableFuture in Cats Effect.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I neither succeeded in finding usages of these, so let's do that!

armanbilge
armanbilge reviewed Mar 18, 2023
View reviewed changes
core/shared/src/main/scala/org/http4s/internal/package.scala
()
}
}

private[http4s] def unsafeToCompletionStage[F[_], A](
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this one too maybe? 😁

@armanbilge
Copy link
Member

Also could not find use of this one, even inside of http4s core.

http4s/core/shared/src/main/scala/org/http4s/internal/package.scala

Lines 65 to 70 in fc60651

private val utf8Bom: Chunk[Byte] = Chunk(0xef.toByte, 0xbb.toByte, 0xbf.toByte)
private[http4s] def skipUtf8ByteOrderMark(chunk: Chunk[Byte]): Chunk[Byte] =
if (chunk.size >= 3 && chunk.take(3) == utf8Bom)
chunk.drop(3)
else chunk

@armanbilge
Copy link
Member

I wonder if we can upstream these ones 🤔

http4s/core/shared/src/main/scala/org/http4s/internal/package.scala

Line 72 in fc60651

// Helper functions for writing Order instances //

@danicheg
Copy link
Member Author

Mehhh, I planned to clean up after my activities in 0.23, not the whole internal package! 😭

@armanbilge
Copy link
Member

😅 sorry, got over-zealous. Merge-at-will!

@danicheg danicheg mentioned this pull request Mar 19, 2023
Open
@danicheg
Copy link
Member Author

Sorry for my laziness 🥲 will leave it as low-hanging fruit for successors #7031

@danicheg danicheg merged commit 09ae763 into http4s:main Mar 20, 2023
12 checks passed
@danicheg danicheg deleted the cleanup-internal branch March 20, 2023 05:03
@armanbilge armanbilge added the behind-the-scenes Appreciated, but not user-facing label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
behind-the-scenes Appreciated, but not user-facing module:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danicheg @armanbilge