Fix resolving of root / URIs #7064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, this case isn't included in the examples in the spec. Any insight? |
|
now that is a scary looking diff. Compared to what it really is 😬 |
rossabaker
approved these changes
Apr 15, 2023
armanbilge
changed the title
danicheg
approved these changes
Apr 15, 2023
| @@ -929,8 +929,10 @@ object Uri extends UriPlatform { | |||
| val target = (base, reference) match { | |||
| case (_, Uri(Some(_), _, _, _, _)) => reference | |||
| case (Uri(s, _, _, _, _), Uri(_, a @ Some(_), p, q, f)) => Uri(s, a, p, q, f) | |||
| case (Uri(s, a, p, q, _), Uri(_, _, pa, Query.empty, f)) if pa.isEmpty => Uri(s, a, p, q, f) | |||
| case (Uri(s, a, p, _, _), Uri(_, _, pa, q, f)) if pa.isEmpty => Uri(s, a, p, q, f) | |||
| case (Uri(s, a, p, q, _), Uri(_, _, pa, Query.empty, f)) if pa.isEmpty && !pa.absolute => | |||
There was a problem hiding this comment.
a skippable minor grumpy nitpick.: does pa.isEmpty && !pa.absolute merely correspond to pa == Path.empty?
There was a problem hiding this comment.
Hmm, that's a good question. It also opens the question that should pa.isEmpty be equivalent to pa == Path.empty? Is / empty or not? 😵
There was a problem hiding this comment.
It's interesting, maybe, it's kinda side effect that Path.empty equals /.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two commits are just some tidying. The fix is in 2096b29.